jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixes #5821 (float32 literal comparison issue) (#5825)

Browse source 
* Remove processing hints for async procs.
* Fixes #5821.
This commit is contained in:
Dominik Picheta 2017-05-17 14:57:06 +01:00 • committed by Andreas Rumpf
commit 06415eb69d
4 changed files with 19 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
compiler/ccgexprs.nim
View file

@ -78,8 +78,10 @@ proc genLiteral(p: BProc, n: PNode, ty: PType): Rope =
[p.module.tmpBase, rope(id)]) [p.module.tmpBase, rope(id)])
else: else:
result = makeCString(n.strVal) result = makeCString(n.strVal)
of nkFloatLit..nkFloat64Lit: of nkFloatLit, nkFloat64Lit:
result = rope(n.floatVal.toStrMaxPrecision) result = rope(n.floatVal.toStrMaxPrecision)
of nkFloat32Lit:
result = rope(n.floatVal.toStrMaxPrecision("f"))
else: else:
internalError(n.info, "genLiteral(" & $n.kind & ')') internalError(n.info, "genLiteral(" & $n.kind & ')')
result = nil result = nil

6
compiler/rodutils.nim
View file

@ -12,17 +12,17 @@ import strutils
proc c_sprintf(buf, frmt: cstring) {.importc: "sprintf", header: "<stdio.h>", nodecl, varargs.} proc c_sprintf(buf, frmt: cstring) {.importc: "sprintf", header: "<stdio.h>", nodecl, varargs.}
proc toStrMaxPrecision*(f: BiggestFloat): string = proc toStrMaxPrecision*(f: BiggestFloat, literalPostfix = ""): string =
if f != f: if f != f:
result = "NAN" result = "NAN"
elif f == 0.0: elif f == 0.0:
result = "0.0" result = "0.0" & literalPostfix
elif f == 0.5 * f: elif f == 0.5 * f:
if f > 0.0: result = "INF" if f > 0.0: result = "INF"
else: result = "-INF" else: result = "-INF"
else: else:
var buf: array[0..80, char] var buf: array[0..80, char]
c_sprintf(buf, "%#.16e", f) c_sprintf(buf, "%#.16e" & literalPostfix, f)
result = $buf result = $buf
proc encodeStr*(s: string, result: var string) = proc encodeStr*(s: string, result: var string) =

3
lib/pure/asyncmacro.nim
View file

@ -306,7 +306,6 @@ proc asyncSingleProc(prc: NimNode): NimNode {.compileTime.} =
" proc/method definition or lambda node expected.") " proc/method definition or lambda node expected.")
let prcName = prc.name.getName let prcName = prc.name.getName
hint("Processing " & prcName & " as an async proc.")
let returnType = prc.params[0] let returnType = prc.params[0]
var baseType: NimNode var baseType: NimNode
@ -527,8 +526,6 @@ macro multisync*(prc: untyped): untyped =
## ##
## The generated async procedures use the ``async`` macro, whereas the ## The generated async procedures use the ``async`` macro, whereas the
## generated synchronous procedures simply strip off the ``await`` calls. ## generated synchronous procedures simply strip off the ``await`` calls.
hint("Processing " & prc[0].getName & " as a multisync proc.")
let (sync, asyncPrc) = splitProc(prc) let (sync, asyncPrc) = splitProc(prc)
result = newStmtList() result = newStmtList()
result.add(asyncSingleProc(asyncPrc)) result.add(asyncSingleProc(asyncPrc))

13
tests/float/tissue5821.nim Normal file
View file

@ -0,0 +1,13 @@
discard """
file: "tissue5821.nim"
output: ''''''
"""
proc main(): void =
let a: float32 = 47.11'f32
doAssert a == 47.11'f32
let b: float64 = 10.234402823e+38'f64
doAssert b != 10.123402823e+38'f64
doAssert b == 10.234402823e+38'f64
main()