jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Atomic inc/dec should use ATOMIC_SEQ_CST (#19212)

Browse source
This commit is contained in:
flywind 2021-12-08 15:40:35 +08:00 • committed by GitHub
commit 0992854941
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/system/atomics.nim
View file

@ -217,7 +217,7 @@ else:
proc atomicInc*(memLoc: var int, x: int = 1): int = proc atomicInc*(memLoc: var int, x: int = 1): int =
when someGcc and hasThreadSupport: when someGcc and hasThreadSupport:
result = atomicAddFetch(memLoc.addr, x, ATOMIC_RELAXED) result = atomicAddFetch(memLoc.addr, x, ATOMIC_SEQ_CST)
elif someVcc and hasThreadSupport: elif someVcc and hasThreadSupport:
result = addAndFetch(memLoc.addr, x) result = addAndFetch(memLoc.addr, x)
inc(result, x) inc(result, x)
@ -228,9 +228,9 @@ proc atomicInc*(memLoc: var int, x: int = 1): int =
proc atomicDec*(memLoc: var int, x: int = 1): int = proc atomicDec*(memLoc: var int, x: int = 1): int =
when someGcc and hasThreadSupport: when someGcc and hasThreadSupport:
when declared(atomicSubFetch): when declared(atomicSubFetch):
result = atomicSubFetch(memLoc.addr, x, ATOMIC_RELAXED) result = atomicSubFetch(memLoc.addr, x, ATOMIC_SEQ_CST)
else: else:
result = atomicAddFetch(memLoc.addr, -x, ATOMIC_RELAXED) result = atomicAddFetch(memLoc.addr, -x, ATOMIC_SEQ_CST)
elif someVcc and hasThreadSupport: elif someVcc and hasThreadSupport:
result = addAndFetch(memLoc.addr, -x) result = addAndFetch(memLoc.addr, -x)
dec(result, x) dec(result, x)