jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

followup #18362: make UnusedImport work robustly (#18366)

Browse source 
* warnDuplicateModuleImport => hintDuplicateModuleImport
* improve DuplicateModuleImport msg, add test
This commit is contained in:
Timothee Cour 2021-06-27 11:39:16 -07:00 • committed by GitHub
commit 0b7361e938
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
14 changed files with 186 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

5
compiler/suggest.nim
View file

@ -32,7 +32,7 @@
# included from sigmatch.nim
import algorithm, sets, prefixmatches, lineinfos, parseutils, linter
import algorithm, sets, prefixmatches, lineinfos, parseutils, linter, tables
from wordrecg import wDeprecated, wError, wAddr, wYield
when defined(nimsuggest):
@ -572,7 +572,8 @@ proc markOwnerModuleAsUsed(c: PContext; s: PSym) =
var i = 0
while i <= high(c.unusedImports):
let candidate = c.unusedImports[i][0]
if candidate == module or c.exportIndirections.contains((candidate.id, s.id)):
if candidate == module or c.importModuleMap.getOrDefault(candidate.id, int.low) == module.id or
c.exportIndirections.contains((candidate.id, s.id)):
# mark it as used:
c.unusedImports.del(i)
else: