Merge pull request #9460 from recloser/fix-printing-uninitialized-strings

Fix printing and comparing uninitialized strings on JS

lib/system/jssys.nim

@@ -228,6 +228,7 @@ proc cstrToNimstr(c: cstring): string {.asmNoStackFrame, compilerproc.} =
 
 proc toJSStr(s: string): cstring {.asmNoStackFrame, compilerproc.} =
   asm """
+  if (`s` === null) return "";
   var len = `s`.length;
   var asciiPart = new Array(len);
   var fcc = String.fromCharCode;
@@ -330,6 +331,8 @@ proc cmp(x, y: string): int =
 proc eqStrings(a, b: string): bool {.asmNoStackFrame, compilerProc.} =
   asm """
     if (`a` == `b`) return true;
+    if (`a` === null && `b`.length == 0) return true;
+    if (`b` === null && `a`.length == 0) return true;
     if ((!`a`) || (!`b`)) return false;
     var alen = `a`.length;
     if (alen != `b`.length) return false;

tests/js/taddnilstr.nim

@@ -1,4 +0,0 @@
-var x = "foo".cstring
-var y: string
-add(y, x)
-doAssert y == "foo"

tests/js/tnilstrs.nim

@@ -0,0 +1,17 @@
+block:
+  var x: string
+  var y = "foo"
+
+  echo x
+  doAssert x == ""
+  doAssert "" == x
+
+  add(x, y)
+  y[0] = 'm'
+  doAssert y == "moo" and x == "foo"
+
+block:
+  var x = "foo".cstring
+  var y: string
+  add(y, x)
+  doAssert y == "foo"

tests/js/tstrconcat.nim

@@ -1,5 +0,0 @@
-var x: string
-var y = "foo"
-add(x, y)
-y[0] = 'm'
-doAssert y == "moo" and x == "foo"