deprecate tables.add (#15047)

This commit is contained in:
Miran 2020-07-25 09:53:47 +02:00 • committed by GitHub
commit 1330597f6d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -484,7 +484,8 @@ proc len*[A, B](t: Table[A, B]): int =
result = t.counter
proc add*[A, B](t: var Table[A, B], key: A, val: B) =
proc add*[A, B](t: var Table[A, B], key: A, val: B) {.deprecated:
"Deprecated since v1.4; it was more confusing than useful, use `[]=`".} =
## Puts a new ``(key, value)`` pair into ``t`` even if ``t[key]`` already exists.
##
## **This can introduce duplicate keys into the table!**
@ -962,7 +963,8 @@ proc len*[A, B](t: TableRef[A, B]): int =
result = t.counter
proc add*[A, B](t: TableRef[A, B], key: A, val: B) =
proc add*[A, B](t: TableRef[A, B], key: A, val: B) {.deprecated:
"Deprecated since v1.4; it was more confusing than useful, use `[]=`".} =
## Puts a new ``(key, value)`` pair into ``t`` even if ``t[key]`` already exists.
##
## **This can introduce duplicate keys into the table!**
@ -1448,7 +1450,8 @@ proc len*[A, B](t: OrderedTable[A, B]): int {.inline.} =
result = t.counter
proc add*[A, B](t: var OrderedTable[A, B], key: A, val: B) =
proc add*[A, B](t: var OrderedTable[A, B], key: A, val: B) {.deprecated:
"Deprecated since v1.4; it was more confusing than useful, use `[]=`".} =
## Puts a new ``(key, value)`` pair into ``t`` even if ``t[key]`` already exists.
##
## **This can introduce duplicate keys into the table!**
@ -1935,7 +1938,8 @@ proc len*[A, B](t: OrderedTableRef[A, B]): int {.inline.} =
result = t.counter
proc add*[A, B](t: OrderedTableRef[A, B], key: A, val: B) =
proc add*[A, B](t: OrderedTableRef[A, B], key: A, val: B) {.deprecated:
"Deprecated since v1.4; it was more confusing than useful, use `[]=`".} =
## Puts a new ``(key, value)`` pair into ``t`` even if ``t[key]`` already exists.
##
## **This can introduce duplicate keys into the table!**