jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

No longer segfault when using a typeclass with a self referencing type (#19467)

Browse source
This commit is contained in:
Jason Beetham 2022-02-02 01:38:21 -07:00 • committed by GitHub
commit 1830a3b505
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
compiler/sigmatch.nim
View file

@ -1688,7 +1688,8 @@ proc typeRel(c: var TCandidate, f, aOrig: PType,
var aa = a var aa = a
while aa.kind in {tyTypeDesc, tyGenericParam} and aa.len > 0: while aa.kind in {tyTypeDesc, tyGenericParam} and aa.len > 0:
aa = lastSon(aa) aa = lastSon(aa)
if aa.kind == tyGenericParam: if aa.kind in {tyGenericParam} + tyTypeClasses:
# If the constraint is a genericParam or typeClass this isGeneric
return isGeneric return isGeneric
result = typeRel(c, f.base, aa, flags) result = typeRel(c, f.base, aa, flags)
if result > isGeneric: result = isGeneric if result > isGeneric: result = isGeneric

12
tests/generics/tgenerics_issues.nim
View file

@ -860,3 +860,15 @@ type
var a: Tile3[int] var a: Tile3[int]
block: # Ensure no segfault from constraint
type
Regex[A: SomeOrdinal] = ref object
val: Regex[A]
MyConstraint = (seq or enum or set)
MyOtherType[A: MyConstraint] = ref object
val: MyOtherType[A]
var
a = Regex[int]()
b = Regex[bool]()
c = MyOtherType[seq[int]]()