jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fixes #10938; fixes #13312; fixes #13918; fixes #20985; always initializes global variables with null values in VM (#21351)

Browse source 
* fixes #10938; always initialize global variable in VM

* fixes importc vars

* there is a pre-existing issue regarding closure types in the VM

* add tests
This commit is contained in:
ringabout 2023-03-02 00:18:09 +08:00 • committed by GitHub
commit 1b1412f3d1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 56 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

46
tests/vm/tvmmisc.nim
View file

@ -564,14 +564,14 @@ block:
block:
static:
let x = int 1
echo x.type # Foo
doAssert $(x.type) == "Foo" # Foo
block:
static:
let x = int 1
let y = x + 1
# Error: unhandled exception: value out of range: -8 notin 0 .. 65535 [RangeDefect]
echo y
doAssert y == 2
type Atom* = object
@ -601,3 +601,45 @@ proc foo(s: sink string) = doAssert s.len == 3
static:
foo("abc")
static:
for i in '1' .. '2': # bug #10938
var s: set[char]
doAssert s == {}
incl(s, i)
for _ in 0 ..< 3: # bug #13312
var s: string
s.add("foo")
doAssert s == "foo"
for i in 1 .. 5: # bug #13918
var arr: array[3, int]
var val: int
doAssert arr == [0, 0, 0] and val == 0
for j in 0 ..< len(arr):
arr[j] = i
val = i
# bug #20985
let a = block:
var groups: seq[seq[int]]
for i in 0 ..< 3:
var group: seq[int]
for j in 0 ..< 3:
group.add j
groups.add group
groups
const b = block:
var groups: seq[seq[int]]
for i in 0 ..< 3:
var group: seq[int]
for j in 0 ..< 3:
group.add j
groups.add group
groups
doAssert a == @[@[0, 1, 2], @[0, 1, 2], @[0, 1, 2]]
doAssert b == @[@[0, 1, 2], @[0, 1, 2], @[0, 1, 2]]