jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[RFC] 'walkDir' now has a new 'checkDir' flag, to mimic behaviour of other languages (#13642)

Browse source 
Co-authored-by: narimiran
This commit is contained in:
Timothee Cour 2020-03-20 08:39:55 -07:00 • committed by GitHub
commit 1d665adecd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 56 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/system/nimscript.nim
View file

@ -30,7 +30,7 @@ proc listDirsImpl(dir: string): seq[string] {.
tags: [ReadIOEffect], raises: [OSError].} = builtin
proc listFilesImpl(dir: string): seq[string] {.
tags: [ReadIOEffect], raises: [OSError].} = builtin
proc removeDir(dir: string) {.
proc removeDir(dir: string, checkDir = true) {.
tags: [ReadIOEffect, WriteIOEffect], raises: [OSError].} = builtin
proc removeFile(dir: string) {.
tags: [ReadIOEffect, WriteIOEffect], raises: [OSError].} = builtin
@ -204,10 +204,10 @@ proc listFiles*(dir: string): seq[string] =
result = listFilesImpl(dir)
checkOsError()
proc rmDir*(dir: string) {.raises: [OSError].} =
proc rmDir*(dir: string, checkDir = false) {.raises: [OSError].} =
## Removes the directory `dir`.
log "rmDir: " & dir:
removeDir dir
removeDir(dir, checkDir = checkDir)
checkOsError()
proc rmFile*(file: string) {.raises: [OSError].} =