jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fixes #10456,#12928 issues when chaining templates to sortedByIt (#15734)

Browse source 
* update c_malloc's to csize_t 

fix for broken --os:ios

* I'm an idiot sorry

* Create talgorithm.nim

* workaround for #10456

I don't understand the intricacies of how lambdalifting and template expansions interact with lent, so i don't know how to fix the real problem, but this sidesteps whatever issue that is.

* working test, use typeof rather than auto
This commit is contained in:
shirleyquirk 2020-10-27 12:38:46 +00:00 • committed by GitHub
commit 218acfe367
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/pure/algorithm.nim
View file

@ -501,7 +501,7 @@ template sortedByIt*(seq1, op: untyped): untyped =
# Nested sort
assert people.sortedByIt((it.age, it.name)) == @[(name: "p2", age: 20),
(name: "p3", age: 30), (name: "p4", age: 30), (name: "p1", age: 60)]
var result = sorted(seq1, proc(x, y: typeof(seq1[0])): int =
var result = sorted(seq1, proc(x, y: typeof(items(seq1), typeOfIter)): int =
var it {.inject.} = x
let a = op
it = y