jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tools/finish: don't quote path with space (#14058) [backport]

Browse source 
Path with spaces should be added as is, quoting them makes utilities
treat the quotes as part of the path. This makes `nim` unable to be used
from the command line even if it appears to be added to user's Path
environment variable.

Even more confusing, Windows 10's PATH editor shows the path without any
quotes, you only see them when you use "Edit text". Took me a good 15
minutes to figure out why couldn't I run `nim` despite it being in Path.
This commit is contained in:
alaviss 2020-04-22 05:51:18 +00:00 • committed by GitHub
commit 22418ce8fb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
tools/finish.nim
View file

@ -123,12 +123,11 @@ when defined(windows):
proc addToPathEnv*(e: string) = proc addToPathEnv*(e: string) =
var p = tryGetUnicodeValue(r"Environment", "Path", HKEY_CURRENT_USER) var p = tryGetUnicodeValue(r"Environment", "Path", HKEY_CURRENT_USER)
let x = if e.contains(Whitespace): "\"" & e & "\"" else: e
if p.len > 0: if p.len > 0:
p.add ";" p.add ";"
p.add x p.add e
else: else:
p = x p = e
setUnicodeValue(r"Environment", "Path", p, HKEY_CURRENT_USER) setUnicodeValue(r"Environment", "Path", p, HKEY_CURRENT_USER)
proc createShortcut(src, dest: string; icon = "") = proc createShortcut(src, dest: string; icon = "") =