jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

StringStreams no longer errors when intialized with literals on arc/orc (#19708)

Browse source
This commit is contained in:
Jason Beetham 2022-04-11 06:27:12 -06:00 • committed by GitHub
commit 26acc97864
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/pure/streams.nim
View file

@ -1274,6 +1274,8 @@ else: # after 1.3 or JS not defined
new(result) new(result)
result.data = s result.data = s
when defined(gcOrc) or defined(gcArc):
prepareMutation(result.data) # Allows us to mutate using `addr` logic like `copyMem`, otherwise it errors.
result.pos = 0 result.pos = 0
result.closeImpl = ssClose result.closeImpl = ssClose
result.atEndImpl = ssAtEnd result.atEndImpl = ssAtEnd

2
tests/stdlib/tstreams.nim
View file

@ -74,3 +74,5 @@ block:
doAssert(ss.peekLine(str)) doAssert(ss.peekLine(str))
doAssert(str == "uick brown fox jumped over the lazy dog.") doAssert(str == "uick brown fox jumped over the lazy dog.")
doAssert(ss.getPosition == 5) # haven't moved doAssert(ss.getPosition == 5) # haven't moved
ss.setPosition(0) # Ensure we dont error with writing over literals on arc/orc #19707
ss.write("hello")