jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add first draft of new osproc.readLines (#15429)

Browse source 
* Add first draft of new osproc.readLines

* Add test for new osproc.readLines

* Rename test to start w/t to run; Also add newline to output

* Suppress hint messages.

* Output should match this time.

* Shoulda picked a program with simpler syntax than ..lol

* Address https://github.com/nim-lang/Nim/pull/15429#issuecomment-701890898
and https://github.com/nim-lang/Nim/pull/15429#issuecomment-701985976 by
factoring `readLines` into `iterator lines` and a wrapper `proc`.

* Address https://github.com/nim-lang/Nim/pull/15429#issuecomment-702127289
and also add a `ReadIOEffect` tag to the iterator (called by the wrapper..
so it should need no separate tag, if I understand correctly).
This commit is contained in:
c-blake 2020-10-01 12:06:38 -04:00 • committed by GitHub
commit 26d656e73e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 73 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
changelog.md
View file

@ -199,6 +199,8 @@
- Add `initUri(isIpv6: bool)` to `uri` module, now `uri` supports parsing ipv6 hostname.
- Add `readLines(p: Process)` to `osproc` module for `startProcess` convenience.
## Language changes
- The `=destroy` hook no longer has to reset its target, as the compiler now automatically inserts