jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix broken runnableExamples for getWeeksInIsoYear (#20193)

Browse source 
Based on what I understand from [Wikipedia](https://en.wikipedia.org/wiki/ISO_week_date#Weeks_per_year), 2001 does not have 53 weeks, but 2004, 2009, 2015, 2020 do. The years 2000 and 2001 seem to be copy pasted from the `getDaysInYear` example above. The result of `getWeeksInIsoYear` also seem to match up with Wikipedia.

That means these runnableExamples were never tested. Why is this the case? I only discovered this in #20091.
This commit is contained in:
metagn 2022-08-11 04:39:18 +03:00 • committed by GitHub
commit 31b7a25e1e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/pure/times.nim
View file

@ -547,8 +547,8 @@ proc getWeeksInIsoYear*(y: IsoYear): IsoWeekRange {.since: (1, 5).} =
## Returns the number of weeks in the specified ISO 8601 week-based year, which can be ## Returns the number of weeks in the specified ISO 8601 week-based year, which can be
## either 53 or 52. ## either 53 or 52.
runnableExamples: runnableExamples:
assert getWeeksInIsoYear(IsoYear(2000)) == 52 assert getWeeksInIsoYear(IsoYear(2019)) == 52
assert getWeeksInIsoYear(IsoYear(2001)) == 53 assert getWeeksInIsoYear(IsoYear(2020)) == 53
var y = int(y) var y = int(y)