jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

add -d:nimStrictMode in CI to keep code from regressing; fixes ConvFromXtoItselfNotNeeded, UnusedImport notes (#16764)

Browse source
This commit is contained in:
Timothee Cour 2021-02-17 10:30:09 -08:00 • committed by GitHub
commit 31bb67a309
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
20 changed files with 43 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

5
lib/pure/asyncfutures.nim
View file

@ -364,7 +364,10 @@ proc read*[T](future: Future[T] | FutureVar[T]): T =
##
## If the result of the future is an error then that error will be raised.
{.push hint[ConvFromXtoItselfNotNeeded]: off.}
let fut = Future[T](future)
when future is Future[T]:
let fut = future
else:
let fut = Future[T](future)
{.pop.}
if fut.finished:
if fut.error != nil: