add -d:nimStrictMode in CI to keep code from regressing; fixes ConvFromXtoItselfNotNeeded, UnusedImport notes (#16764)

This commit is contained in:
Timothee Cour 2021-02-17 10:30:09 -08:00 • committed by GitHub
commit 31bb67a309
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
20 changed files with 43 additions and 23 deletions

View file

@ -683,7 +683,7 @@ proc main() =
case p.key.normalize
of "print", "verbose": optPrintResults = true
of "failing": optFailing = true
of "pedantic": discard # deadcode
of "pedantic": discard # deadcode refs https://github.com/nim-lang/Nim/issues/16731
of "targets":
targetsStr = p.val
gTargets = parseTargets(targetsStr)
@ -739,7 +739,7 @@ proc main() =
var r = initResults()
case action
of "all":
#processCategory(r, Category"megatest", p.cmdLineRest.string, testsDir, runJoinableTests = false)
#processCategory(r, Category"megatest", p.cmdLineRest, testsDir, runJoinableTests = false)
var myself = quoteShell(getAppFilename())
if targetsStr.len > 0:
@ -798,8 +798,7 @@ proc main() =
p.next
processPattern(r, pattern, p.cmdLineRest, simulate)
of "r", "run":
var subPath = p.key
let (cat, path) = splitTestFile(subPath)
let (cat, path) = splitTestFile(p.key)
processSingleTest(r, cat.Category, p.cmdLineRest, path, gTargets, targetsSet)
of "html":
generateHtml(resultsFile, optFailing)