Use onThreadCreation to set default SSL context for each thread (#5265)

Fixes: #4998

lib/pure/httpclient.nim

@@ -50,13 +50,13 @@
 ##
 ##   echo client.postContent("http://validator.w3.org/check", multipart=data)
 ##
-## You can also make post requests with custom headers. 
+## You can also make post requests with custom headers.
 ## This example sets ``Content-Type`` to ``application/json``
 ## and uses a json object for the body
 ##
 ## .. code-block:: Nim
 ##   import httpclient, json
-##   
+##
 ##   let client = newHttpClient()
 ##   client.headers = newHttpHeaders({ "Content-Type": "application/json" })
 ##   let body = %*{
@@ -303,9 +303,12 @@ proc parseResponse(s: Socket, getBody: bool, timeout: int): Response =
 
 when not defined(ssl):
   type SSLContext = ref object
-  let defaultSSLContext: SSLContext = nil
+var defaultSSLContext {.threadvar.}: SSLContext
-else:
+when defined(ssl):
-  let defaultSSLContext = newContext(verifyMode = CVerifyNone)
+  defaultSSLContext = newContext(verifyMode = CVerifyNone)
+  when compileOption("threads"):
+    onThreadCreation do ():
+      defaultSSLContext = newContext(verifyMode = CVerifyNone)
 
 proc newProxy*(url: string, auth = ""): Proxy =
   ## Constructs a new ``TProxy`` object.

tests/stdlib/thttpclient.nim

@@ -1,5 +1,5 @@
 discard """
-  cmd: "nim c -d:ssl $file"
+  cmd: "nim c --threads:on -d:ssl $file"
 """
 
 import strutils