jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Non-base10 overflow allowed if bit-stable. Tests.

Browse source
This commit is contained in:
Oscar Campbell 2015-06-11 01:53:34 +02:00
commit 3998220f86
1 changed files with 15 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

18
compiler/lexer.nim
View file

@ -482,9 +482,21 @@ proc getNumber(L: var TLexer): TToken =
of tkFloat64Lit: result.fNumber = (cast[PFloat64](addr(xi)))[] of tkFloat64Lit: result.fNumber = (cast[PFloat64](addr(xi)))[]
else: internalError(getLineInfo(L), "getNumber") else: internalError(getLineInfo(L), "getNumber")
# Simple bounds check # Bounds checks. Non decimal literals are allowed to overflow the range of
if result.tokType notin floatTypes and xi != result.iNumber: # the datatype as long as their pattern don't overflow _bitwise_, hence
lexMessageLitNum(L, errNumberOutOfRange, startpos) # below checks of signed sizes against uint*.high is deliberate:
# (0x80'u8 = 128, 0x80'i8 = -128, etc == OK)
if result.tokType notin floatTypes:
let outOfRange = case result.tokType:
of tkUInt8Lit, tkUInt16Lit, tkUInt32Lit: result.iNumber != xi
of tkInt8Lit: (xi > BiggestInt(uint8.high))
of tkInt16Lit: (xi > BiggestInt(uint16.high))
of tkInt32Lit: (xi > BiggestInt(uint32.high))
else: false
if outOfRange:
echo "out of range num: ", result.iNumber, " vs ", xi
lexMessageLitNum(L, errNumberOutOfRange, startpos)
else: else:
case result.tokType case result.tokType