jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Thread attributes should be destroyed using the pthread_attr_destroy() (#13293)

Browse source 
On some OSes (such as FreeBSD or Solaris), pthread_attr_init allocate
memory. So it is necessary to deallocate that memory by using
pthread_attr_destroy.
This commit is contained in:
Hiroki Noda 2020-01-30 01:33:21 +09:00 • committed by GitHub
commit 3ab1274231
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/system/threadlocalstorage.nim
View file

@ -151,9 +151,11 @@ else:
tv_sec: Time
tv_nsec: clong
proc pthread_attr_init(a1: var Pthread_attr) {.
proc pthread_attr_init(a1: var Pthread_attr): cint {.
importc, header: pthreadh.}
proc pthread_attr_setstacksize(a1: var Pthread_attr, a2: int) {.
proc pthread_attr_setstacksize(a1: var Pthread_attr, a2: int): cint {.
importc, header: pthreadh.}
proc pthread_attr_destroy(a1: var Pthread_attr): cint {.
importc, header: pthreadh.}
proc pthread_create(a1: var SysThread, a2: var Pthread_attr,

5
lib/system/threads.nim
View file

@ -313,10 +313,11 @@ else:
t.dataFn = tp
when hasSharedHeap: t.core.stackSize = ThreadStackSize
var a {.noinit.}: Pthread_attr
pthread_attr_init(a)
pthread_attr_setstacksize(a, ThreadStackSize)
doAssert pthread_attr_init(a) == 0
doAssert pthread_attr_setstacksize(a, ThreadStackSize) == 0
if pthread_create(t.sys, a, threadProcWrapper[TArg], addr(t)) != 0:
raise newException(ResourceExhaustedError, "cannot create thread")
doAssert pthread_attr_destroy(a) == 0
proc pinToCpu*[Arg](t: var Thread[Arg]; cpu: Natural) =
## Pins a thread to a `CPU`:idx:.