jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix for js strict mode (#18799)

Browse source 
* Assignments, which would accidentally create global
variables, instead throw an error in strict mode

* Assignment to a getter-only property

Co-authored-by: Sven Keller <s.keller@cortona.de>
This commit is contained in:
Sven Keller 2021-09-04 12:53:02 +02:00 • committed by GitHub
commit 3c2edd142b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/jsgen.nim
View file

@ -1769,7 +1769,7 @@ proc genVarInit(p: PProc, v: PSym, n: PNode) =
inc p.extraIndent inc p.extraIndent
elif useGlobalPragmas: elif useGlobalPragmas:
lineF(p, "if (globalThis.$1 === undefined) {$n", varName) lineF(p, "if (globalThis.$1 === undefined) {$n", varName)
varCode = $varName varCode = "globalThis." & $varName
inc p.extraIndent inc p.extraIndent
else: else:
varCode = "var $2" varCode = "var $2"

5
lib/system/jssys.nim
View file

@ -593,12 +593,9 @@ proc nimCopy(dest, src: JSRef, ti: PNimType): JSRef =
`result` = null; `result` = null;
} }
else { else {
if (`dest` === null || `dest` === undefined) { if (`dest` === null || `dest` === undefined || `dest`.length != `src`.length) {
`dest` = new Array(`src`.length); `dest` = new Array(`src`.length);
} }
else {
`dest`.length = `src`.length;
}
`result` = `dest`; `result` = `dest`;
for (var i = 0; i < `src`.length; ++i) { for (var i = 0; i < `src`.length; ++i) {
`result`[i] = nimCopy(`result`[i], `src`[i], `ti`.base); `result`[i] = nimCopy(`result`[i], `src`[i], `ti`.base);