jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

followup #17852, disallow all:on for now (#18311)

Browse source
This commit is contained in:
Timothee Cour 2021-06-20 13:49:14 -07:00 • committed by GitHub
commit 40ec8184ad
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/commands.nim
View file

@ -217,6 +217,8 @@ proc processSpecificNote*(arg: string, state: TSpecialWord, pass: TCmdLinePass,
localError(conf, info, errOnOrOffExpectedButXFound % arg) localError(conf, info, errOnOrOffExpectedButXFound % arg)
else: else:
let isOn = val == "on" let isOn = val == "on"
if isOn and id.normalize == "all":
localError(conf, info, "only 'all:off' is supported")
for n in notes: for n in notes:
if n notin conf.cmdlineNotes or pass == passCmd1: if n notin conf.cmdlineNotes or pass == passCmd1:
if pass == passCmd1: incl(conf.cmdlineNotes, n) if pass == passCmd1: incl(conf.cmdlineNotes, n)

3
doc/advopt.txt
View file

@ -51,7 +51,8 @@ Advanced options:
--hints:on|off|list. `on|off` enables or disables hints. --hints:on|off|list. `on|off` enables or disables hints.
`list` reports which hints are selected. `list` reports which hints are selected.
--hint:X:on|off turn specific hint X on|off. `hint:X` means `hint:X:on`, --hint:X:on|off turn specific hint X on|off. `hint:X` means `hint:X:on`,
as with similar flags. `all` can be used for "all hints". as with similar flags. `all` is the set of all hints
(only `all:off` is supported).
--hintAsError:X:on|off turn specific hint X into an error on|off --hintAsError:X:on|off turn specific hint X into an error on|off
-w:on|off|list, --warnings:on|off|list -w:on|off|list, --warnings:on|off|list
same as `--hints` but for warnings. same as `--hints` but for warnings.