jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix numbering in contributing.rst (#16042)

Browse source
This commit is contained in:
Timothee Cour 2020-11-18 19:41:01 -08:00 • committed by GitHub
commit 44442520bc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
doc/contributing.rst
View file

@ -407,7 +407,6 @@ General commit rules
#!/bin/sh #!/bin/sh
git diff --check --cached || exit $? git diff --check --cached || exit $?
5. Describe your commit and use your common sense. 5. Describe your commit and use your common sense.
Example commit message: Example commit message:
@ -418,11 +417,10 @@ General commit rules
(e.g.: partially fixed) and won't close the issue when committed. (e.g.: partially fixed) and won't close the issue when committed.
6. PR body (not just PR title) should contain references to fixed/referenced github 6. PR body (not just PR title) should contain references to fixed/referenced github
issues, e.g.: `fix #123` or `refs #123`. This is so that you get proper cross issues, e.g.: `fix #123` or `refs #123`. This is so that you get proper cross
referencing from linked issue to the PR (github won't make those links with just referencing from linked issue to the PR (github won't make those links with just
PR title, and commit messages aren't always sufficient to ensure that, e.g. PR title, and commit messages aren't always sufficient to ensure that, e.g.
can't be changed after a PR is merged). can't be changed after a PR is merged).
7. Commits should be always be rebased against devel (so a fast forward 7. Commits should be always be rebased against devel (so a fast forward
merge can happen) merge can happen)