jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[isolation]fix empty ref object bug (#17471)

Browse source 
* fix nim js cmp fails at CT

* [Minor]fix empty ref object for isolation

* Update compiler/isolation_check.nim

* Update compiler/isolation_check.nim

Co-authored-by: Clyybber <darkmine956@gmail.com>

Co-authored-by: Clyybber <darkmine956@gmail.com>
This commit is contained in:
flywind 2021-03-24 16:44:24 +08:00 • committed by GitHub
commit 465a41c308
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
compiler/isolation_check.nim
View file

@ -100,7 +100,12 @@ proc checkIsolate*(n: PNode): bool =
for it in n: for it in n:
result = checkIsolate(it.lastSon) result = checkIsolate(it.lastSon)
if not result: break if not result: break
of nkCaseStmt, nkObjConstr: of nkCaseStmt:
for i in 1..<n.len:
result = checkIsolate(n[i].lastSon)
if not result: break
of nkObjConstr:
result = true
for i in 1..<n.len: for i in 1..<n.len:
result = checkIsolate(n[i].lastSon) result = checkIsolate(n[i].lastSon)
if not result: break if not result: break
@ -123,4 +128,3 @@ proc checkIsolate*(n: PNode): bool =
else: else:
# no ref, no cry: # no ref, no cry:
result = true result = true

8
tests/stdlib/tisolation.nim
View file

@ -8,6 +8,14 @@ import std/[isolation, json]
proc main() = proc main() =
block:
type
Empty = ref object
var x = isolate(Empty())
discard extract(x)
block: # string literals block: # string literals
var data = isolate("string") var data = isolate("string")
doAssert data.extract == "string" doAssert data.extract == "string"