jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add column number to instantiation info (#7376)

Browse source 
* Add column number to instantiation info

Instantiation info left out column number for no good reason. This adds
it in as the third element of the tuple.

* Fix test that failed and added change to changelog

An assertion test failed because it was declaring a type that was
expected to be populated by instantiationInfo with the old signature.

Also added the changes to the changelog as it is a breaking change.
This commit is contained in:
PMunch 2018-04-12 20:02:04 +02:00 • committed by Andreas Rumpf
commit 4f1725ad61
4 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
compiler/semmagic.nim
View file

@ -81,8 +81,11 @@ proc semInstantiationInfo(c: PContext, n: PNode): PNode =
filename.strVal = if useFullPaths != 0: info.toFullPath else: info.toFilename
var line = newNodeIT(nkIntLit, n.info, getSysType(tyInt))
line.intVal = toLinenumber(info)
var column = newNodeIT(nkIntLit, n.info, getSysType(tyInt))
column.intVal = toColumn(info)
result.add(filename)
result.add(line)
result.add(column)
proc toNode(t: PType, i: TLineInfo): PNode =
result = newNodeIT(nkType, i, t)