jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix bug in semgnrc: runnableExamples should not semcheck, even with > 1 arg (#14768)

Browse source
This commit is contained in:
Timothee Cour 2020-06-23 01:06:36 -07:00 • committed by GitHub
commit 511bd947d3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/semgnrc.nim
View file

@ -265,7 +265,7 @@ proc semGenericStmt(c: PContext, n: PNode,
# We're not interested in the example code during this pass so let's # We're not interested in the example code during this pass so let's
# skip it # skip it
if s.magic == mRunnableExamples: if s.magic == mRunnableExamples:
inc first first = result.safeLen # see trunnableexamples.fun3
of skGenericParam: of skGenericParam:
result[0] = newSymNodeTypeDesc(s, fn.info) result[0] = newSymNodeTypeDesc(s, fn.info)
onUse(fn.info, s) onUse(fn.info, s)

10
tests/nimdoc/trunnableexamples.nim
View file

@ -91,6 +91,16 @@ when true: # runnableExamples with rdoccmd
proc fun2*() = proc fun2*() =
runnableExamples "-d:foo": discard # checks that it also works inside procs runnableExamples "-d:foo": discard # checks that it also works inside procs
template fun3Impl(): untyped =
runnableExamples(rdoccmd="-d:foo"):
nonexistant
# bugfix: this shouldn't be semchecked when `runnableExamples`
# has more than 1 argument
discard
proc fun3*[T]() =
fun3Impl()
when false: # future work when false: # future work
# passing non-string-litterals (for reuse) # passing non-string-litterals (for reuse)
const a = "-b:cpp" const a = "-b:cpp"