jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remove deprecation from math.round (#15224)

Browse source
This commit is contained in:
Miran 2020-08-25 15:59:42 +02:00 • committed by GitHub
commit 5163fe7d87
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
changelog.md
View file

@ -164,7 +164,14 @@
echo foo echo foo
``` ```
- Proc `math.round` is no longer deprecated. The advice to use `strformat` instead
cannot be applied to every use case. The limitations and the (lack of) reliability
of `round` are well documented.
## Language changes ## Language changes
- The `=destroy` hook no longer has to reset its target, as the compiler now automatically inserts - The `=destroy` hook no longer has to reset its target, as the compiler now automatically inserts
`wasMoved` calls where needed. `wasMoved` calls where needed.
- In the newruntime it is now allowed to assign to the discriminator field - In the newruntime it is now allowed to assign to the discriminator field

3
lib/pure/math.nim
View file

@ -768,8 +768,7 @@ else: # JS
## ( 6.5 mod -2.5) == 1.5 ## ( 6.5 mod -2.5) == 1.5
## (-6.5 mod -2.5) == -1.5 ## (-6.5 mod -2.5) == -1.5
proc round*[T: float32|float64](x: T, places: int): T {. proc round*[T: float32|float64](x: T, places: int): T =
deprecated: "use strformat module instead".} =
## Decimal rounding on a binary floating point number. ## Decimal rounding on a binary floating point number.
## ##
## This function is NOT reliable. Floating point numbers cannot hold ## This function is NOT reliable. Floating point numbers cannot hold