jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ARC: closure bugfixes (#12677)

Browse source 
* ARC: closure bugfixes
* progress
* ARC closures: create =hooks for captured parameters
* ARC: always destroy constructions like tuples, arrays properly, even in edge cases
* fixes a regression
This commit is contained in:
Andreas Rumpf 2019-11-18 12:33:44 +01:00 • committed by GitHub
commit 5278cf80eb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 72 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

7
compiler/sempass2.nim
View file

@ -709,11 +709,11 @@ proc track(tracked: PEffects, n: PNode) =
# p's effects are ours too:
var a = n.sons[0]
let op = a.typ
if getConstExpr(tracked.ownerModule, n, tracked.graph) != nil:
return
if n.typ != nil:
if tracked.owner.kind != skMacro and n.typ.skipTypes(abstractVar).kind != tyOpenArray:
createTypeBoundOps(tracked, n.typ, n.info)
if getConstExpr(tracked.ownerModule, n, tracked.graph) != nil:
return
if a.kind == nkCast and a[1].typ.kind == tyProc:
a = a[1]
# XXX: in rare situations, templates and macros will reach here after
@ -883,6 +883,9 @@ proc track(tracked: PEffects, n: PNode) =
if n.len == 2: track(tracked, n.sons[1])
of nkObjUpConv, nkObjDownConv, nkChckRange, nkChckRangeF, nkChckRange64:
if n.len == 1: track(tracked, n.sons[0])
of nkBracket:
for i in 0 ..< safeLen(n): track(tracked, n.sons[i])
createTypeBoundOps(tracked, n.typ, n.info)
else:
for i in 0 ..< safeLen(n): track(tracked, n.sons[i])