jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix #14568 (#14583)

Browse source 
* Fix #14568
* Add testcase
* Fix bogus test
* Adapt other failing tests
* Declarations are always first writes
This commit is contained in:
Clyybber 2020-06-07 23:32:41 +02:00 • committed by GitHub
commit 52841dba09
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 49 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

27
tests/arc/tmovebug.nim
View file

@ -36,6 +36,10 @@ fff
mmm
sink me (sink)
assign me (not sink)
sink me (not sink)
sinked and not optimized to a bitcopy
sinked and not optimized to a bitcopy
sinked and not optimized to a bitcopy
'''
"""
@ -273,10 +277,10 @@ type ME = object
who: string
proc `=`(x: var ME, y: ME) =
if x.who.len > 0: echo "assign ",x.who
if y.who.len > 0: echo "assign ",y.who
proc `=sink`(x: var ME, y: ME) =
if x.who.len > 0: echo "sink ",x.who
if y.who.len > 0: echo "sink ",y.who
var dump: ME
template use(x) = dump = x
@ -302,3 +306,22 @@ proc shouldNotSink() =
use(x) # Not ok without the '[else]'
shouldNotSink()
# bug #14568
import os
type O2 = object
s: seq[int]
proc `=sink`(dest: var O2, src: O2) =
echo "sinked and not optimized to a bitcopy"
var testSeq: O2
proc Update(): void =
# testSeq.add(0) # uncommenting this line fixes the leak
testSeq = O2(s: @[])
testSeq.s.add(0)
for i in 1..3:
Update()