From 53cd61546dc798fc0f08baf0813f579a90d7e766 Mon Sep 17 00:00:00 2001 From: Araq Date: Tue, 21 Sep 2010 07:48:35 +0200 Subject: [PATCH] proper parameter order for os.copyFile/os.moveFile --- lib/pure/os.nim | 8 ++------ web/news.txt | 1 + 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/lib/pure/os.nim b/lib/pure/os.nim index 6ad39d5ca..a1dd5450d 100755 --- a/lib/pure/os.nim +++ b/lib/pure/os.nim @@ -620,11 +620,9 @@ proc sameFileContent*(path1, path2: string): bool {.rtl, extern: "nos$1".} = close(a) close(b) -proc copyFile*(dest, source: string) {.deprecated, rtl, extern: "nos$1".} = +proc copyFile*(source, dest: string) {.rtl, extern: "nos$1".} = ## Copies a file from `source` to `dest`. If this fails, ## `EOS` is raised. - ## **Deprecated since version 0.8.8**: Use this proc with named arguments - ## only, because the order will change! when defined(Windows): if CopyFileA(source, dest, 0'i32) == 0'i32: OSError() else: @@ -650,10 +648,8 @@ proc copyFile*(dest, source: string) {.deprecated, rtl, extern: "nos$1".} = close(s) close(d) -proc moveFile*(dest, source: string) {.deprecated, rtl, extern: "nos$1".} = +proc moveFile*(source, dest: string) {.rtl, extern: "nos$1".} = ## Moves a file from `source` to `dest`. If this fails, `EOS` is raised. - ## **Deprecated since version 0.8.8**: Use this proc with named arguments - ## only, because the order will change! if crename(source, dest) != 0'i32: OSError() proc removeFile*(file: string) {.rtl, extern: "nos$1".} = diff --git a/web/news.txt b/web/news.txt index f6ca438e0..8036c9c16 100755 --- a/web/news.txt +++ b/web/news.txt @@ -24,6 +24,7 @@ Bugfixes Changes affecting backwards compatibility ----------------------------------------- +- Reversed parameter order for ``os.copyFile`` and ``os.moveFile``!!! - Procs not marked as ``procvar`` cannot only be passed to a procvar anymore, unless they are used in the same module. - Deprecated ``times.getStartMilsecs``: Use ``epochTime`` or ``cpuTime``