jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix #16033 nim js --gc:arc works and ignores --gc:arc (#16036)

Browse source
This commit is contained in:
Timothee Cour 2020-11-18 14:28:52 -08:00 • committed by GitHub
commit 557dcfd87d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
compiler/commands.nim
View file

@ -499,7 +499,10 @@ proc processSwitch*(switch, arg: string, pass: TCmdLinePass, info: TLineInfo;
of "project": of "project":
processOnOffSwitchG(conf, {optWholeProject, optGenIndex}, arg, pass, info) processOnOffSwitchG(conf, {optWholeProject, optGenIndex}, arg, pass, info)
of "gc": of "gc":
if conf.backend == backendJs: if conf.backend == backendJs or conf.command == "js":
# for: bug #16033
# This might still be imperfect, in rarse corner cases
# (where command is reset in nimscript, maybe).
return return
expectArg(conf, switch, arg, pass, info) expectArg(conf, switch, arg, pass, info)
if pass in {passCmd2, passPP}: if pass in {passCmd2, passPP}:

10
tests/arc/t16033.nim Normal file
View file

@ -0,0 +1,10 @@
discard """
targets: "c js"
matrix: "--gc:arc"
"""
# bug #16033
when defined js:
doAssert not compileOption("gc", "arc")
else:
doAssert compileOption("gc", "arc")