jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

suggestion to respect typedarray type (#19257)

Browse source 
* suggestion to respect typedarray

* Update jssys.nim

Co-authored-by: Sven Keller <s.keller@cortona.de>
This commit is contained in:
Sven Keller 2021-12-16 08:58:32 +01:00 • committed by GitHub
commit 5d2bab7558
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 27 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

28
lib/system/jssys.nim
View file

@ -587,7 +587,33 @@ proc nimCopy(dest, src: JSRef, ti: PNimType): JSRef =
else:
asm "`result` = (`dest` === null || `dest` === undefined) ? {} : `dest`;"
nimCopyAux(result, src, ti.node)
of tySequence, tyArrayConstr, tyOpenArray, tyArray:
of tyArrayConstr, tyArray:
# In order to prevent a type change (TypedArray -> Array) and to have better copying performance,
# arrays constructors are considered separately
asm """
if(ArrayBuffer.isView(`src`)) {
if(`dest` === null || `dest` === undefined || `dest`.length != `src`.length) {
`dest` = new `src`.constructor(`src`);
} else {
`dest`.set(`src`, 0);
}
`result` = `dest`;
} else {
if (`src` === null) {
`result` = null;
}
else {
if (`dest` === null || `dest` === undefined || `dest`.length != `src`.length) {
`dest` = new Array(`src`.length);
}
`result` = `dest`;
for (var i = 0; i < `src`.length; ++i) {
`result`[i] = nimCopy(`result`[i], `src`[i], `ti`.base);
}
}
}
"""
of tySequence, tyOpenArray:
asm """
if (`src` === null) {
`result` = null;