From 5d947bb791e8149c1eb0ffc7c775b7a115605770 Mon Sep 17 00:00:00 2001
From: Amjad Ben Hedhili <amjadhedhili@outlook.com>
Date: Tue, 6 Sep 2022 20:33:40 +0100
Subject: [PATCH] Replace `if` by `case` in JS `isSimpleExpr` (#20267)

use case stmt
---
 compiler/jsgen.nim | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/compiler/jsgen.nim b/compiler/jsgen.nim
index a221b3127..fbf8b4ec0 100644
--- a/compiler/jsgen.nim
+++ b/compiler/jsgen.nim
@@ -315,17 +315,19 @@ proc useMagic(p: PProc, name: string) =
 
 proc isSimpleExpr(p: PProc; n: PNode): bool =
   # calls all the way down --> can stay expression based
-  if n.kind in nkCallKinds+{nkBracketExpr, nkDotExpr, nkPar, nkTupleConstr} or
-      (n.kind in {nkObjConstr, nkBracket, nkCurly}):
+  case n.kind
+  of nkCallKinds, nkBracketExpr, nkDotExpr, nkPar, nkTupleConstr,
+    nkObjConstr, nkBracket, nkCurly:
     for c in n:
       if not p.isSimpleExpr(c): return false
     result = true
-  elif n.kind == nkStmtListExpr:
+  of nkStmtListExpr:
     for i in 0..<n.len-1:
       if n[i].kind notin {nkCommentStmt, nkEmpty}: return false
     result = isSimpleExpr(p, n.lastSon)
-  elif n.isAtom:
-    result = true
+  else:
+    if n.isAtom:
+      result = true
 
 proc getTemp(p: PProc, defineInLocals: bool = true): Rope =
   inc(p.unique)