jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Implement https://forum.nim-lang.org/t/7848#50018 (#17874)

Browse source 
* Implement https://forum.nim-lang.org/t/7848#50018 with just the same
`SuccessX` hint category, build mode on a separate, final line, and
no change to how the mode is spelled for -d:release/-d:danger.

* Change to add a new BuildMode hint category and keep testament in sync
as per comment.

* Add "--hint:buildmode:off" to `defaultHintsOff`.

* Remove as requested.

* As requested for tests clean up.

* Address code review.

* Address code review.

* Mirror db456423116a9b19666f551f4d38aded3964c2e2
This commit is contained in:
c-blake 2021-04-29 02:55:43 -04:00 • committed by GitHub
commit 601c050fcb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 17 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

3
testament/testament.nim
View file

@ -107,7 +107,8 @@ proc isSuccess(input: string): bool =
# that may appear in user config (eg: `--filenames`).
# Passing `XDG_CONFIG_HOME= testament args...` can be used to ignore user config
# stored in XDG_CONFIG_HOME, refs https://wiki.archlinux.org/index.php/XDG_Base_Directory
input.startsWith("Hint: ") and input.endsWith("[SuccessX]")
input.startsWith("Hint: ") and
(input.endsWith("[SuccessX]") or input.endsWith("[BuildMode]"))
proc getFileDir(filename: string): string =
result = filename.splitFile().dir