jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remove unused and misleading FilenameOption.foShort (#15982)

Browse source
This commit is contained in:
Timothee Cour 2020-11-16 13:52:02 -08:00 • committed by GitHub
commit 61352d5a20
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/msgs.nim
View file

@ -237,7 +237,6 @@ type FilenameOption* = enum
foRelProject # relative to project path, e.g.: ../foo.nim foRelProject # relative to project path, e.g.: ../foo.nim
foMagicSauce # magic sauce, shortest of (foAbs, foRelProject) foMagicSauce # magic sauce, shortest of (foAbs, foRelProject)
foName # lastPathPart, e.g.: foo.nim foName # lastPathPart, e.g.: foo.nim
foShort # foName without extension, e.g.: foo
foStacktrace # if optExcessiveStackTrace: foAbs else: foName foStacktrace # if optExcessiveStackTrace: foAbs else: foName
proc toFilenameOption*(conf: ConfigRef, fileIdx: FileIndex, opt: FilenameOption): string = proc toFilenameOption*(conf: ConfigRef, fileIdx: FileIndex, opt: FilenameOption): string =
@ -255,7 +254,6 @@ proc toFilenameOption*(conf: ConfigRef, fileIdx: FileIndex, opt: FilenameOption)
else: else:
relPath relPath
of foName: result = toProjPath(conf, fileIdx).lastPathPart of foName: result = toProjPath(conf, fileIdx).lastPathPart
of foShort: result = toFilename(conf, fileIdx)
of foStacktrace: of foStacktrace:
if optExcessiveStackTrace in conf.globalOptions: if optExcessiveStackTrace in conf.globalOptions:
result = toFilenameOption(conf, fileIdx, foAbs) result = toFilenameOption(conf, fileIdx, foAbs)