Stop useless suggestion of unsafeAddr (#10598)

Fixes #10594
2019-02-08 08:59:38 +01:00 · 2019-02-08 08:59:38 +01:00 · 6b88ce3384
commit 6b88ce3384
parent c7c495f08a
3 changed files with 14 additions and 2 deletions
--- a/compiler/semmagic.nim
+++ b/compiler/semmagic.nim
@ -16,7 +16,12 @@ proc semAddr(c: PContext; n: PNode; isUnsafeAddr=false): PNode =
  if x.kind == nkSym:
    x.sym.flags.incl(sfAddrTaken)
  if isAssignable(c, x, isUnsafeAddr) notin {arLValue, arLocalLValue}:
-    localError(c.config, n.info, errExprHasNoAddress)
+    # Do not suggest the use of unsafeAddr if this expression already is a
+    # unsafeAddr
+    if isUnsafeAddr:
+      localError(c.config, n.info, errExprHasNoAddress)
+    else:
+      localError(c.config, n.info, errExprHasNoAddress & "; maybe use 'unsafeAddr'")
  result.add x
  result.typ = makePtrType(c, x.typ)