cmp(x, y: string) now uses memcmp rather than strcmp (#6869) (#6968)

2017-12-24 09:23:17 -05:00 · 2017-12-24 09:23:17 -05:00 · 6bd3a2826f
commit 6bd3a2826f
parent ca9f3b47d4
3 changed files with 28 additions and 5 deletions
--- a/lib/system.nim
+++ b/lib/system.nim
@ -2916,7 +2916,10 @@ when not defined(JS): #and not defined(nimscript):
      elif x > y: result = 1
      else: result = 0
    else:
-      result = int(c_strcmp(x, y))
+      let minlen = min(x.len, y.len)
+      result = int(c_memcmp(x.cstring, y.cstring, minlen.csize))
+      if result == 0:
+        result = x.len - y.len

  when defined(nimscript):
    proc readFile*(filename: string): string {.tags: [ReadIOEffect], benign.}