jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix #9695 asyncmacro: tfuturevar fails when activated [backport: 1.0] (#16090)

Browse source 
* fix asyncmacro

* Apply suggestions from code review

* Update lib/pure/asyncmacro.nim
This commit is contained in:
flywind 2020-11-23 00:16:42 +08:00 • committed by GitHub
commit 6f1a72069a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
lib/pure/asyncmacro.nim
View file

@ -118,7 +118,8 @@ proc getFutureVarIdents(params: NimNode): seq[NimNode] {.compileTime.} =
for i in 1 ..< len(params): for i in 1 ..< len(params):
expectKind(params[i], nnkIdentDefs) expectKind(params[i], nnkIdentDefs)
if params[i][1].kind == nnkBracketExpr and if params[i][1].kind == nnkBracketExpr and
params[i][1][0].eqIdent("futurevar"): params[i][1][0].eqIdent(FutureVar.astToStr):
## eqIdent: first char is case sensitive!!!
result.add(params[i][0]) result.add(params[i][0])
proc isInvalidReturnType(typeName: string): bool = proc isInvalidReturnType(typeName: string): bool =

5
tests/async/tfuturevar.nim
View file

@ -1,8 +1,3 @@
discard """
action: compile
"""
# XXX: action should be run!
import asyncdispatch import asyncdispatch
proc completeOnReturn(fut: FutureVar[string], x: bool) {.async.} = proc completeOnReturn(fut: FutureVar[string], x: bool) {.async.} =