jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fixes #20397; fixes stylecheck regression (#20398)

Browse source 
* fixes  #20397; fixes stylecheck

* add testcase
This commit is contained in:
ringabout 2022-09-22 03:04:33 +08:00 • committed by GitHub
commit 70c25c45d6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 20 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
compiler/linter.nim
View file

@ -93,6 +93,7 @@ proc nep1CheckDefImpl(conf: ConfigRef; info: TLineInfo; s: PSym; k: TSymKind) =
template styleCheckDef*(ctx: PContext; info: TLineInfo; sym: PSym; k: TSymKind) = template styleCheckDef*(ctx: PContext; info: TLineInfo; sym: PSym; k: TSymKind) =
## Check symbol definitions adhere to NEP1 style rules. ## Check symbol definitions adhere to NEP1 style rules.
if optStyleCheck in ctx.config.options and # ignore if styleChecks are off if optStyleCheck in ctx.config.options and # ignore if styleChecks are off
{optStyleHint, optStyleError} * ctx.config.globalOptions != {} and # check only if hint/error is enabled
hintName in ctx.config.notes and # ignore if name checks are not requested hintName in ctx.config.notes and # ignore if name checks are not requested
ctx.config.belongsToProjectPackage(ctx.module) and # ignore foreign packages ctx.config.belongsToProjectPackage(ctx.module) and # ignore foreign packages
optStyleUsages notin ctx.config.globalOptions and # ignore if requested to only check name usage optStyleUsages notin ctx.config.globalOptions and # ignore if requested to only check name usage

4
tests/stylecheck/t20397.nim Normal file
View file

@ -0,0 +1,4 @@
{.hintAsError[Name]:on.}
var a_b = 1
discard a_b
{.hintAsError[Name]:off.}

8
tests/stylecheck/t20397_1.nim Normal file
View file

@ -0,0 +1,8 @@
discard """
matrix: "--styleCheck:off"
"""
{.hintAsError[Name]:on.}
var a_b = 1
discard a_b
{.hintAsError[Name]:off.}

7
tests/stylecheck/t20397_2.nim Normal file
View file

@ -0,0 +1,7 @@
discard """
errormsg: "'a_b' should be: 'aB'"
matrix: "--styleCheck:error"
"""
var a_b = 1
discard a_b