jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove bit about opening files not raising (#15654)

Browse source 
Resolved #473 

I am removing this bit because this advice to not throw on recoverable-from cases like a file failing to open is actually not respected by Nim standard library. `readFile` and `readLines` both throw and exceptions must be used as a method of control flow for the recovery from that. There are alternatives, like opening a file handle instead of using these helpers, but that's less convenient than these helper methods for cases where you really want to just slurp up a file to memory and use a fallback value if it doesn't exist or is for whatever reason not readable.
This commit is contained in:
Tomáš Hübelbauer 2020-10-20 13:36:19 +02:00 • committed by GitHub
commit 725c7caa02
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
doc/tut2.rst
View file

@ -345,10 +345,8 @@ The compiler will prevent you from raising an exception created on the stack.
All raised exceptions should at least specify the reason for being raised in All raised exceptions should at least specify the reason for being raised in
the ``msg`` field. the ``msg`` field.
A convention is that exceptions should be raised in *exceptional* cases: A convention is that exceptions should be raised in *exceptional* cases,
For example, if a file cannot be opened, this should not raise an they should not be used as an alternative method of control flow.
exception since this is quite common (the file may not exist).
Raise statement Raise statement
--------------- ---------------