jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[bugfix] Fixes async IO operations stalling even after socket is closed. (#11232)

Browse source
This commit is contained in:
Dominik Picheta 2019-06-12 16:07:05 +01:00 • committed by Andreas Rumpf
commit 73c44c6e9b
4 changed files with 192 additions and 53 deletions
Download patch file Download diff file Expand all files Collapse all files

12
lib/pure/asyncfutures.nim
View file

@ -393,11 +393,13 @@ proc asyncCheck*[T](future: Future[T]) =
## This should be used instead of ``discard`` to discard void futures,
## or use ``waitFor`` if you need to wait for the future's completion.
assert(not future.isNil, "Future is nil")
future.callback =
proc () =
if future.failed:
injectStacktrace(future)
raise future.error
# TODO: We can likely look at the stack trace here and inject the location
# where the `asyncCheck` was called to give a better error stack message.
proc asyncCheckCallback() =
if future.failed:
injectStacktrace(future)
raise future.error
future.callback = asyncCheckCallback
proc `and`*[T, Y](fut1: Future[T], fut2: Future[Y]): Future[void] =
## Returns a future which will complete once both ``fut1`` and ``fut2``