jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

net: don't clear error queue unless shutdown() will be performed

Browse source
This commit is contained in:
Leorize 2020-06-03 13:43:17 -05:00 • committed by Andreas Rumpf
commit 78982b52f0
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/pure/net.nim
View file

@ -1006,7 +1006,6 @@ proc close*(socket: Socket) =
try: try:
when defineSsl: when defineSsl:
if socket.isSsl and socket.sslHandle != nil: if socket.isSsl and socket.sslHandle != nil:
ErrClearError()
# Don't call SSL_shutdown if the connection has not been fully # Don't call SSL_shutdown if the connection has not been fully
# established, see: # established, see:
# https://github.com/openssl/openssl/issues/710#issuecomment-253897666 # https://github.com/openssl/openssl/issues/710#issuecomment-253897666
@ -1015,6 +1014,7 @@ proc close*(socket: Socket) =
# it is valid, under the TLS standard, to perform a unidirectional # it is valid, under the TLS standard, to perform a unidirectional
# shutdown i.e not wait for the peers "close notify" alert with a second # shutdown i.e not wait for the peers "close notify" alert with a second
# call to SSL_shutdown # call to SSL_shutdown
ErrClearError()
let res = SSL_shutdown(socket.sslHandle) let res = SSL_shutdown(socket.sslHandle)
if res == 0: if res == 0:
discard discard