jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Httpclient improvements (#15919)

Browse source 
* Allow passing Uri instead of strings

* Teach httpclient about 308

* Deprecate request proc where httpMethod is string

* More use of HttpMethod enum

Also fix handling of 308, I forgot to add the hunk to the previous
commit.

* Well behaved redirect handler

* Also remove Transfer-Encoding

* Removed unused proc

* Secure redirection rules

Strip sensitive headers for cross-domain redirects.

* Allow httpMethod to be a string again

This way unknown http verbs can be used without any problem.

* Respect user-specified Host header

* Missed multipart argument.

* Try another method

* add changelog

* Fix hidden deprecation warning, parseEnum failing

* This is wrong

* Have to do it manually, parseEnum is not suitable

* Review comments

* update

Co-authored-by: LemonBoy <thatlemon@gmail.com>
Co-authored-by: Dominik Picheta <dominikpicheta@googlemail.com>
This commit is contained in:
Antonis Geralis 2021-01-10 15:40:53 +02:00 • committed by GitHub
commit 7bde6aa37f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 147 additions and 110 deletions
Download patch file Download diff file Expand all files Collapse all files

57
lib/pure/httpcore.nim
View file

@ -29,24 +29,26 @@ type
HttpVer11,
HttpVer10
HttpMethod* = enum ## the requested HttpMethod
HttpHead, ## Asks for the response identical to the one that would
## correspond to a GET request, but without the response
## body.
HttpGet, ## Retrieves the specified resource.
HttpPost, ## Submits data to be processed to the identified
## resource. The data is included in the body of the
## request.
HttpPut, ## Uploads a representation of the specified resource.
HttpDelete, ## Deletes the specified resource.
HttpTrace, ## Echoes back the received request, so that a client
## can see what intermediate servers are adding or
## changing in the request.
HttpOptions, ## Returns the HTTP methods that the server supports
## for specified address.
HttpConnect, ## Converts the request connection to a transparent
## TCP/IP tunnel, usually used for proxies.
HttpPatch ## Applies partial modifications to a resource.
HttpMethod* = enum ## the requested HttpMethod
HttpHead = "HEAD" ## Asks for the response identical to the one that
## would correspond to a GET request, but without
## the response body.
HttpGet = "GET" ## Retrieves the specified resource.
HttpPost = "POST" ## Submits data to be processed to the identified
## resource. The data is included in the body of
## the request.
HttpPut = "PUT" ## Uploads a representation of the specified
## resource.
HttpDelete = "DELETE" ## Deletes the specified resource.
HttpTrace = "TRACE" ## Echoes back the received request, so that a
## client
## can see what intermediate servers are adding or
## changing in the request.
HttpOptions = "OPTIONS" ## Returns the HTTP methods that the server
## supports for specified address.
HttpConnect = "CONNECT" ## Converts the request connection to a transparent
## TCP/IP tunnel, usually used for proxies.
HttpPatch = "PATCH" ## Applies partial modifications to a resource.
const
@ -150,7 +152,6 @@ func newHttpHeaders*(keyValuePairs:
else:
result.table[key] = @[pair.val]
func `$`*(headers: HttpHeaders): string {.inline.} =
$headers.table
@ -378,21 +379,3 @@ func is4xx*(code: HttpCode): bool {.inline.} =
func is5xx*(code: HttpCode): bool {.inline.} =
## Determines whether ``code`` is a 5xx HTTP status code.
code.int in {500 .. 599}
func `$`*(httpMethod: HttpMethod): string {.inline.} =
runnableExamples:
doAssert $HttpHead == "HEAD"
doAssert $HttpPatch == "PATCH"
doAssert $HttpGet == "GET"
doAssert $HttpPost == "POST"
result = case httpMethod
of HttpHead: "HEAD"
of HttpGet: "GET"
of HttpPost: "POST"
of HttpPut: "PUT"
of HttpDelete: "DELETE"
of HttpTrace: "TRACE"
of HttpOptions: "OPTIONS"
of HttpConnect: "CONNECT"
of HttpPatch: "PATCH"