jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix jsre (#19917)

Browse source 
* Fixes for jsre to make it more safe at runtime on some edge cases

* https://github.com/nim-lang/Nim/pull/19917#issuecomment-1162692893
This commit is contained in:
Juan Carlos 2022-06-28 03:13:17 -03:00 • committed by GitHub
commit 7c31b6a47b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/js/jsre.nim
View file

@ -33,13 +33,13 @@ func compile*(self: RegExp; pattern: cstring; flags: cstring) {.importjs: "#.com
func replace*(pattern: cstring; self: RegExp; replacement: cstring): cstring {.importjs: "#.replace(#, #)".} func replace*(pattern: cstring; self: RegExp; replacement: cstring): cstring {.importjs: "#.replace(#, #)".}
## Returns a new string with some or all matches of a pattern replaced by given replacement ## Returns a new string with some or all matches of a pattern replaced by given replacement
func split*(pattern: cstring; self: RegExp): seq[cstring] {.importjs: "#.split(#)".} func split*(pattern: cstring; self: RegExp): seq[cstring] {.importjs: "(#.split(#) || [])".}
## Divides a string into an ordered list of substrings and returns the array ## Divides a string into an ordered list of substrings and returns the array
func match*(pattern: cstring; self: RegExp): seq[cstring] {.importjs: "#.match(#)".} func match*(pattern: cstring; self: RegExp): seq[cstring] {.importjs: "(#.match(#) || [])".}
## Returns an array of matches of a RegExp against given string ## Returns an array of matches of a RegExp against given string
func exec*(self: RegExp; pattern: cstring): seq[cstring] {.importjs: "#.exec(#)".} func exec*(self: RegExp; pattern: cstring): seq[cstring] {.importjs: "(#.exec(#) || [])".}
## Executes a search for a match in its string parameter. ## Executes a search for a match in its string parameter.
func toCstring*(self: RegExp): cstring {.importjs: "#.toString()".} func toCstring*(self: RegExp): cstring {.importjs: "#.toString()".}
@ -87,3 +87,5 @@ runnableExamples:
assert "do1ne".split(jsregex) == @["do".cstring, "ne".cstring] assert "do1ne".split(jsregex) == @["do".cstring, "ne".cstring]
jsregex.compile(r"[lw]", r"i") jsregex.compile(r"[lw]", r"i")
assert "hello world".replace(jsregex,"X") == "heXlo world" assert "hello world".replace(jsregex,"X") == "heXlo world"
let digitsRegex: RegExp = newRegExp(r"\d")
assert "foo".match(digitsRegex) == @[]