Error -> Defect for defects (#13908)

* Error -> Defect for defects

The distinction between Error and Defect is subjective,
context-dependent and somewhat arbitrary, so when looking at an
exception, it's hard to guess what it is - this happens often when
looking at a `raises` list _without_ opening the corresponding
definition and digging through layers of inheritance.

With the help of a little consistency in naming, it's at least possible
to start disentangling the two error types and the standard lib can set
a good example here.
This commit is contained in:
Jacek Sieka 2020-04-28 19:56:01 +02:00 • committed by GitHub
commit 7d6cbf290a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
92 changed files with 323 additions and 300 deletions

View file

@ -154,16 +154,16 @@ type
x1: string
case kind1: bool
of false: y1: string
of true:
of true:
y2: seq[string]
case kind2: bool
of true: z1: string
of false:
of false:
z2: seq[string]
flag: bool
x2: string
proc test_myobject =
proc test_myobject =
var x: MyObject
x.x1 = "x1"
x.x2 = "x2"
@ -183,7 +183,7 @@ proc test_myobject =
try:
x.kind1 = x.flag # flag is not accesible
except FieldError:
except FieldDefect:
echo "prevented"
doAssert(x.x1 == "x1")