jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Error -> Defect for defects (#13908)

Browse source 
* Error -> Defect for defects

The distinction between Error and Defect is subjective,
context-dependent and somewhat arbitrary, so when looking at an
exception, it's hard to guess what it is - this happens often when
looking at a `raises` list _without_ opening the corresponding
definition and digging through layers of inheritance.

With the help of a little consistency in naming, it's at least possible
to start disentangling the two error types and the standard lib can set
a good example here.
This commit is contained in:
Jacek Sieka 2020-04-28 19:56:01 +02:00 • committed by GitHub
commit 7d6cbf290a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
92 changed files with 323 additions and 300 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/exception/texceptions.nim
View file

@ -89,10 +89,10 @@ block:
result.add(1212)
try:
try:
raise newException(AssertionError, "a")
raise newException(AssertionDefect, "a")
finally:
result.add(42)
except AssertionError:
except AssertionDefect:
result.add(99)
finally:
result.add(10)
@ -104,7 +104,7 @@ block:
result.add(-1)
except ValueError:
result.add(-1)
except IndexError:
except IndexDefect:
result.add(2)
except:
result.add(3)