fix #17853 (ascii message separator broke json nim dump) (#17887)

This commit is contained in:
Timothee Cour 2021-04-29 02:25:08 -07:00 • committed by GitHub
commit 87229e272e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 24 additions and 4 deletions

View file

@ -71,6 +71,7 @@ ret=[s1:foobar s2:foobar age:25 pi:3.14]
else: # don't run twice the same test
import std/strutils
import std/json
template check2(msg) = doAssert msg in output, output
block: # tests with various options `nim doc --project --index --docroot`
@ -317,3 +318,13 @@ compiling: v3
running: v3
running: v2
""", ret
block: # nim dump
let cmd = fmt"{nim} dump --dump.format:json -d:D20210428T161003 --hints:off ."
let (ret, status) = execCmdEx(cmd)
doAssert status == 0
let j = ret.parseJson
# sanity checks
doAssert "D20210428T161003" in j["defined_symbols"].to(seq[string])
doAssert j["version"].to(string) == NimVersion
doAssert j["nimExe"].to(string) == getCurrentCompilerExe()

View file

@ -1,15 +1,18 @@
discard """
output: '''Error: cannot open 'a.nim'\31
output: '''
Error: cannot open 'a.nim'\31
Error: cannot open 'b.nim'\31
'''
targets: "c"
"""
import osproc
from std/os import getCurrentCompilerExe
var ps: seq[Process] # compile & run 2 progs in parallel
const nim = getCurrentCompilerExe()
for prog in ["a", "b"]:
ps.add startProcess("nim", "",
ps.add startProcess(nim, "",
["r", "--hint[Conf]=off", "--hint[Processing]=off", prog],
options = {poUsePath, poDaemon, poStdErrToStdOut})