jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ValueError now inherits from CatchableError (#10246)

Browse source
This commit is contained in:
Oscar Nihlgård 2019-01-10 08:49:57 +01:00 • committed by Andreas Rumpf
commit 87232a38e4
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
changelog.md
View file

@ -30,7 +30,9 @@
- `osproc.execProcess` now also takes a `workingDir` parameter. - `osproc.execProcess` now also takes a `workingDir` parameter.
- `options.UnpackError` is no longer a ref type and inherits from `System.Defect` instead of `System.ValueError`. - `options.UnpackError` is no longer a ref type and inherits from `system.Defect` instead of `system.ValueError`.
- `system.ValueError` now inherits from `system.CatchableError` instead of `system.Defect`.
- nre's `RegexMatch.{captureBounds,captures}[]` no longer return `Option` or - nre's `RegexMatch.{captureBounds,captures}[]` no longer return `Option` or
`nil`/`""`, respectivly. Use the newly added `n in p.captures` method to `nil`/`""`, respectivly. Use the newly added `n in p.captures` method to

2
lib/system.nim
View file

@ -606,7 +606,7 @@ type
## Raised when assertion is proved wrong. ## Raised when assertion is proved wrong.
## ##
## Usually the result of using the `assert() template <#assert>`_. ## Usually the result of using the `assert() template <#assert>`_.
ValueError* = object of Defect ## \ ValueError* = object of CatchableError ## \
## Raised for string and object conversion errors. ## Raised for string and object conversion errors.
KeyError* = object of ValueError ## \ KeyError* = object of ValueError ## \
## Raised if a key cannot be found in a table. ## Raised if a key cannot be found in a table.