jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix #7241 (#13779)

Browse source 
finalize() should run in insert()
This commit is contained in:
itsumura-h 2020-04-03 16:38:05 +09:00 • committed by GitHub
commit 87e6b88f3b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
lib/impure/db_sqlite.nim
View file

@ -184,6 +184,9 @@ proc tryExec*(db: DbConn, query: SqlQuery,
let x = step(stmt) let x = step(stmt)
if x in {SQLITE_DONE, SQLITE_ROW}: if x in {SQLITE_DONE, SQLITE_ROW}:
result = finalize(stmt) == SQLITE_OK result = finalize(stmt) == SQLITE_OK
else:
discard finalize(stmt)
result = false
proc exec*(db: DbConn, query: SqlQuery, args: varargs[string, `$`]) {. proc exec*(db: DbConn, query: SqlQuery, args: varargs[string, `$`]) {.
tags: [ReadDbEffect, WriteDbEffect].} = tags: [ReadDbEffect, WriteDbEffect].} =
@ -531,6 +534,8 @@ proc tryInsertID*(db: DbConn, query: SqlQuery,
result = last_insert_rowid(db) result = last_insert_rowid(db)
if finalize(stmt) != SQLITE_OK: if finalize(stmt) != SQLITE_OK:
result = -1 result = -1
else:
discard finalize(stmt)
proc insertID*(db: DbConn, query: SqlQuery, proc insertID*(db: DbConn, query: SqlQuery,
args: varargs[string, `$`]): int64 {.tags: [WriteDbEffect].} = args: varargs[string, `$`]): int64 {.tags: [WriteDbEffect].} =