jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix the range of destroyed elements when shrinking a seq (#11785)

Browse source
This commit is contained in:
Jörg Wollenschläger 2019-07-19 23:46:47 +09:00 • committed by Andreas Rumpf
commit 903d06bab8
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/core/seqs.nim
View file

@ -138,7 +138,7 @@ proc shrink*[T](x: var seq[T]; newLen: Natural) =
mixin `=destroy` mixin `=destroy`
sysAssert newLen <= x.len, "invalid newLen parameter for 'shrink'" sysAssert newLen <= x.len, "invalid newLen parameter for 'shrink'"
when not supportsCopyMem(T): when not supportsCopyMem(T):
for i in countdown(x.len - 1, newLen - 1): for i in countdown(x.len - 1, newLen):
`=destroy`(x[i]) `=destroy`(x[i])
# XXX This is wrong for const seqs that were moved into 'x'! # XXX This is wrong for const seqs that were moved into 'x'!
cast[ptr NimSeqV2[T]](addr x).len = newLen cast[ptr NimSeqV2[T]](addr x).len = newLen