jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fixes #20244; fixes castSizes warnings (#21102)

Browse source 
* fixes #20244; fixes castSizes warnings

* fixes js

* fixes js

* fixes js

* fixes

* typo

* extend using uint64

* Update lib/std/syncio.nim
This commit is contained in:
ringabout 2022-12-22 15:27:11 +08:00 • committed by GitHub
commit 93b59da490
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 20 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/ccgutils.nim
View file

@ -53,7 +53,7 @@ proc hashString*(conf: ConfigRef; s: string): BiggestInt =
a = a + (a shl 3) a = a + (a shl 3)
a = a xor (a shr 11) a = a xor (a shr 11)
a = a + (a shl 15) a = a + (a shl 15)
result = cast[Hash](a) result = cast[Hash](uint(a))
template getUniqueType*(key: PType): PType = key template getUniqueType*(key: PType): PType = key

1
compiler/condsyms.nim
View file

@ -146,6 +146,7 @@ proc initDefines*(symbols: StringTableRef) =
defineSymbol("nimHasCallsitePragma") defineSymbol("nimHasCallsitePragma")
defineSymbol("nimHasAmbiguousEnumHint") defineSymbol("nimHasAmbiguousEnumHint")
defineSymbol("nimHasWarnCastSizes")
defineSymbol("nimHasOutParams") defineSymbol("nimHasOutParams")
defineSymbol("nimHasSystemRaisesDefect") defineSymbol("nimHasSystemRaisesDefect")
defineSymbol("nimHasWarnUnnamedBreak") defineSymbol("nimHasWarnUnnamedBreak")

4
compiler/nim.cfg
View file

@ -31,6 +31,10 @@ define:useStdoutAsStdmsg
warning[ObservableStores]:off warning[ObservableStores]:off
@end @end
@if nimHasWarnCastSizes:
warning[CastSizes]:on
@end
@if nimHasWarningAsError: @if nimHasWarningAsError:
warningAsError[GcUnsafe2]:on warningAsError[GcUnsafe2]:on
@end @end

12
lib/pure/strutils.nim
View file

@ -944,14 +944,26 @@ func toHex*[T: SomeInteger](x: T, len: Positive): string =
doAssert b.toHex(4) == "1001" doAssert b.toHex(4) == "1001"
doAssert toHex(62, 3) == "03E" doAssert toHex(62, 3) == "03E"
doAssert toHex(-8, 6) == "FFFFF8" doAssert toHex(-8, 6) == "FFFFF8"
when defined(js):
toHexImpl(cast[BiggestUInt](x), len, x < 0) toHexImpl(cast[BiggestUInt](x), len, x < 0)
else:
when T is SomeSignedInt:
toHexImpl(cast[BiggestUInt](BiggestInt(x)), len, x < 0)
else:
toHexImpl(BiggestUInt(x), len, x < 0)
func toHex*[T: SomeInteger](x: T): string = func toHex*[T: SomeInteger](x: T): string =
## Shortcut for `toHex(x, T.sizeof * 2)` ## Shortcut for `toHex(x, T.sizeof * 2)`
runnableExamples: runnableExamples:
doAssert toHex(1984'i64) == "00000000000007C0" doAssert toHex(1984'i64) == "00000000000007C0"
doAssert toHex(1984'i16) == "07C0" doAssert toHex(1984'i16) == "07C0"
when defined(js):
toHexImpl(cast[BiggestUInt](x), 2*sizeof(T), x < 0) toHexImpl(cast[BiggestUInt](x), 2*sizeof(T), x < 0)
else:
when T is SomeSignedInt:
toHexImpl(cast[BiggestUInt](BiggestInt(x)), 2*sizeof(T), x < 0)
else:
toHexImpl(BiggestUInt(x), 2*sizeof(T), x < 0)
func toHex*(s: string): string {.rtl.} = func toHex*(s: string): string {.rtl.} =
## Converts a bytes string to its hexadecimal representation. ## Converts a bytes string to its hexadecimal representation.