From 944a0ac318a7c3758ddb46f8d972c7f322c1f540 Mon Sep 17 00:00:00 2001 From: Joey Date: Wed, 6 Jan 2021 14:03:59 -0700 Subject: [PATCH] DELETE requests should always have a content-length header Not having DELETE in this list is causing hanging when trying to close webdriver sessions in [halonium](https://github.com/halonium/halonium/issues/10) and likely any other implementation of the webdriver protocol. Both at least chromedriver and geckodriver are affected by this issue. --- lib/pure/httpclient.nim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pure/httpclient.nim b/lib/pure/httpclient.nim index 3093f5564..a6d7edf33 100644 --- a/lib/pure/httpclient.nim +++ b/lib/pure/httpclient.nim @@ -980,7 +980,7 @@ proc requestAux(client: HttpClient | AsyncHttpClient, url, httpMethod: string, var data: seq[string] if multipart != nil and multipart.content.len > 0: data = await client.format(multipart) - elif httpMethod in ["POST", "PATCH", "PUT"] or body.len != 0: + elif httpMethod in ["POST", "PATCH", "PUT", "DELETE"] or body.len != 0: client.headers["Content-Length"] = $body.len when client is AsyncHttpClient: